Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR06 doc string fixes #28946

Merged
merged 49 commits into from
Oct 13, 2019
Merged

PR06 doc string fixes #28946

merged 49 commits into from
Oct 13, 2019

Conversation

tolaa001
Copy link
Contributor

This PR contains doctrine PR06 fixes mostly doing the conversion below(not that many left to fix :)):

boolean to bool

string to str

integer to int

Tests unchanged

black pandas ran successfully

@tolaa001
updated boolean to bool for api.extension.extensionarray methods
1229963
@tolaa001
updating categorical.from codes args with type string to str and bool…
34db4a3 
…ean to bool
@tolaa001
converting DatetimeLikeArrayMixin.value_count arg type from boolean t…
ad9e2ce 
…o bool
@tolaa001
converting methods in datetimelike module with string args to str
78d1853
@tolaa001
converting method arg types boolean to bool in integer.py
d0e9bd4
@tolaa001
converting method arg types string to str in period.py
3b5347f
@tolaa001
converting boolean to bool in docstring in cast.py
9b64f96
@tolaa001
converting boolean to bool in common.py
6fca012
@tolaa001
converting boolean to bool in concat.py
6535906
@tolaa001
converting string to str in dtypes.py
cd84668
@tolaa001
converting boolean to bool in missing.py
5828d24
@tolaa001
Merge remote-tracking branch 'upstream/master' into more_doc_contribu…
26bbd72 
…tion
@tolaa001
change to array-like of int
1c33d6f
@tolaa001
change to 'category' from the str 'category'
8b362d2
@tolaa001
changed / to ,
073e45f
@tolaa001
Merge remote-tracking branch 'upstream/master' into more_doc_contribu…
794e93c 
…tion
@tolaa001
catrgorical fix
a30457a
@tolaa001
Merge remote-tracking branch 'upstream/master' into more_doc_contribu…
3ccd062 
…tion
@tolaa001
docstring fix for to_json method
fb3690b
@tolaa001
docstring fix for unstack method
90f04c9
@tolaa001
docstring fix for nunique method
4cf387e
@tolaa001
docstring fix for indexer_at_time method
e4bc525
@tolaa001
docstring fix for sortlevel method
817b73d
@tolaa001
docstring fix for to_frame method
7f08a4b
@tolaa001
docstring fix for categoricalindex
3f8db1d
@tolaa001
docstring fix for shift method
8bdcddf
@tolaa001
docstring fix for eval method
c535f45
@tolaa001
docstring fix for interval_rangemethod
9c43759
@tolaa001
docstring fix for infer_freq method
452baf4
@tolaa001
docstring fix for to_numeric method
46a83fc
@simonjayhawkins
Copy link
Member

Thanks @tolaa001 . can you merge master. some of these look familiar.

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Oct 12, 2019
simonjayhawkins
simonjayhawkins requested changes Oct 12, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tolaa001 for working on this. A few suggestions.

pandas/core/computation/eval.py Outdated Show resolved Hide resolved
pandas/core/computation/eval.py Outdated Show resolved Hide resolved
pandas/core/tools/numeric.py Outdated Show resolved Hide resolved
pandas/io/pytables.py Outdated Show resolved Hide resolved
pandas/io/pytables.py Outdated Show resolved Hide resolved
pandas/io/stata.py Outdated Show resolved Hide resolved
pandas/io/stata.py Outdated Show resolved Hide resolved
pandas/io/stata.py Outdated Show resolved Hide resolved
pandas/io/stata.py Outdated Show resolved Hide resolved
pandas/io/stata.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Oct 13, 2019 •
edited
Loading

Hello @tolaa001! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-13 17:49:47 UTC

simonjayhawkins
simonjayhawkins approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolaa001 lgtm @datapythonista

datapythonista
datapythonista reviewed Oct 13, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, few minor things and we're done. Thanks!

pandas/core/computation/eval.py Outdated Show resolved Hide resolved
pandas/core/reshape/tile.py Outdated Show resolved Hide resolved
pandas/io/json/_json.py Outdated Show resolved Hide resolved
pandas/io/pytables.py Outdated Show resolved Hide resolved
pandas/io/pytables.py Outdated Show resolved Hide resolved
pandas/io/pytables.py Outdated Show resolved Hide resolved
pandas/io/pytables.py Outdated Show resolved Hide resolved
@simonjayhawkins simonjayhawkins merged commit 2931f02 into pandas-dev:master Oct 13, 2019
@simonjayhawkins
Copy link
Member

Thanks @tolaa001

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@tolaa001 @proost
PR06 doc string fixes (pandas-dev#28946)
ea89902
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@tolaa001 @proost
PR06 doc string fixes (pandas-dev#28946)
8dc70ff
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@tolaa001
PR06 doc string fixes (pandas-dev#28946)
19c3ea2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tolaa001 @simonjayhawkins @pep8speaks @datapythonista